Merged
Conversation
bdice
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back CUDA 11 jobs since we are no longer certain that we will definitively be dropping CUDA 11 in 25.08. Moreover, in the process of forward-merging the various 25.06 migrations we accidentally had a CUDA 11 Python build job sneak back into our matrix. Since the corresponding C++ build job did not make it back in, CI has been failing to build on 25.08 anyway since the Python jobs cannot download a suitable C++ artifact (example). For now, the simplest way to get 25.08 back into a reasonable state is to revert back to the state of the matrix before the CUDA 11 drop and then make sure we have Python 3.13 coverage.